Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue when installing the npm package
npm i gbfs-validator --save
after the submodule addition. I discovered from the package.jsonpostinstall
script will trigger when users install the package usingnpm i gbfs-validator --save
. This caused an error where it would try to update the submodules when trying to download the package.Solution
The
prepare
lifecycle script will trigger a submodule update on a localnpm install
but NOT when a user downloads the packagenpm i gbfs-validator --save
. It will also trigger just beforenpm publish
. This is the functionality we wanted from the beginningNote: I deployed version 1.0.11 locally to make sure this fix works, and it does!